Fix message filter being put in wrong position by optimizer#1648
Merged
christian-schilling merged 1 commit intomasterfrom Dec 11, 2025
Merged
Fix message filter being put in wrong position by optimizer#1648christian-schilling merged 1 commit intomasterfrom
christian-schilling merged 1 commit intomasterfrom
Conversation
| common_post.map(|c| (c, rest)) | ||
| } else if let Op::Prefix(_) = to_op(c) { | ||
| common_post.map(|c| (c, rest)) | ||
| } else if let Op::Message(..) = to_op(c) { |
Member
There was a problem hiding this comment.
I wonder why this was limited to prefix in the first place. Maybe we should look into allowing factorizing all filters here instead of adding more special cases 🤔
Thoughts?
Collaborator
Author
There was a problem hiding this comment.
Would prefer to merge this as a hotfix and then create an issue. For all filters I think we'd need a good test strategy, maybe something like guided fuzzing to discover "unsound" edge cases
christian-schilling
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.